Hi guys, updated to 1) make it behind a build flag, 2) include deep object verification, 3) respond to various comments.
http://codereview.chromium.org/11085070/diff/3001/src/flag-definitions.h File src/flag-definitions.h (right): http://codereview.chromium.org/11085070/diff/3001/src/flag-definitions.h#newcode572 src/flag-definitions.h:572: On 2012/10/11 12:42:46, Michael Starzinger wrote:
Also drop the empty line.
Done. http://codereview.chromium.org/11085070/diff/3001/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/11085070/diff/3001/src/heap.cc#newcode468 src/heap.cc:468: allow_allocation(true); On 2012/10/11 12:42:46, Michael Starzinger wrote:
Neither the zapping nor the verification should do any allocation, so
we can
move this down right before the printing calls I think.
Done. http://codereview.chromium.org/11085070/diff/3001/src/heap.h File src/heap.h (right): http://codereview.chromium.org/11085070/diff/3001/src/heap.h#newcode1279 src/heap.h:1279: #endif On 2012/10/11 12:42:46, Michael Starzinger wrote:
Empty newline after the #endif
Done. http://codereview.chromium.org/11085070/diff/3001/src/objects-inl.h File src/objects-inl.h (right): http://codereview.chromium.org/11085070/diff/3001/src/objects-inl.h#newcode3647 src/objects-inl.h:3647: #ifndef DEBUG On 2012/10/11 12:42:46, Michael Starzinger wrote:
I think it would be useful to have a static inline function Heap::ShouldZapGarbage() that captures this predicate so to not spread
it out
across the entire code base.
Done. http://codereview.chromium.org/11085070/diff/3001/src/objects-inl.h#newcode3789 src/objects-inl.h:3789: #ifndef DEBUG On 2012/10/11 12:42:46, Michael Starzinger wrote:
Likewise.
Done. http://codereview.chromium.org/11085070/diff/3001/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/11085070/diff/3001/src/objects.cc#newcode2188 src/objects.cc:2188: if (trim_mode != FROM_GC || zapInFromGCMode) { On 2012/10/11 12:42:46, Michael Starzinger wrote:
See comment about Heap::ShouldZapGarbage earlier.
Done. http://codereview.chromium.org/11085070/diff/3001/src/objects.cc#newcode9065 src/objects.cc:9065: On 2012/10/11 12:42:46, Michael Starzinger wrote:
Additional empty newline here.
Done. http://codereview.chromium.org/11085070/diff/3001/src/spaces.h File src/spaces.h (right): http://codereview.chromium.org/11085070/diff/3001/src/spaces.h#newcode2553 src/spaces.h:2553: virtual void Verify(); On 2012/10/11 12:42:46, Michael Starzinger wrote:
Empty newline after declaration.
Done. http://codereview.chromium.org/11085070/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
