https://codereview.chromium.org/11574031/diff/88001/build/common.gypi
File build/common.gypi (right):
https://codereview.chromium.org/11574031/diff/88001/build/common.gypi#newcode90
build/common.gypi:90: 'v8_enable_vtunejit%': 0,
Since this variable will only affect d8, it doesn't need to be in
common.gypi, but can go into d8.gyp instead. In there, the only thing it
should do is control d8's dependency on the to-be-created v8vtune gyp
target.
https://codereview.chromium.org/11574031/diff/88001/build/common.gypi#newcode144
build/common.gypi:144: 'defines': ['ENABLE_VTUNE_JIT_INTERFACE',],
These definitions should then go into the to-be-created v8vtune target
into a direct_dependent_settings section (so they'll automatically
affect targets depending on v8vtune).
https://codereview.chromium.org/11574031/diff/88001/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):
https://codereview.chromium.org/11574031/diff/88001/tools/gyp/v8.gyp#newcode773
tools/gyp/v8.gyp:773: '../../src/third_party/vtune/vtune-jit.h',
On 2013/03/07 14:19:20, danno wrote:
These belong in d8's list gyp file, not V8.
In light of your other comments, I think you mean:
v8-vtune.h should go into d8.gyp; the others into a to-be-created
src/third_party/vtune/v8vtune.gyp containing a target definition for the
v8vtune library, which in turn d8 should depend on.
https://codereview.chromium.org/11574031/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
