https://codereview.chromium.org/11574031/diff/127001/src/third_party/vtune/v8vtune.gyp
File src/third_party/vtune/v8vtune.gyp (right):
https://codereview.chromium.org/11574031/diff/127001/src/third_party/vtune/v8vtune.gyp#newcode34
src/third_party/vtune/v8vtune.gyp:34: 'dependencies': [
nit: please don't use tabs for indentation, only spaces.
https://codereview.chromium.org/11574031/diff/127001/src/third_party/vtune/v8vtune.gyp#newcode38
src/third_party/vtune/v8vtune.gyp:38: '../../../src',
Since you're now fully relying on the public V8 API, there's no reason
at all to have this include_dirs section.
https://codereview.chromium.org/11574031/diff/127001/src/third_party/vtune/v8vtune.gyp#newcode41
src/third_party/vtune/v8vtune.gyp:41:
'../../../src/third_party/vtune/ittnotify_config.h',
As I said before, you don't need paths for files that are in the same
directory as this .gyp file. So just list them as:
'sources': [
'ittnotify_config.h',
'ittnotify_types.h',
# and so on
],
https://codereview.chromium.org/11574031/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
