https://codereview.chromium.org/11574031/diff/99001/src/third_party/vtune/v8vtune.gyp
File src/third_party/vtune/v8vtune.gyp (right):
https://codereview.chromium.org/11574031/diff/99001/src/third_party/vtune/v8vtune.gyp#newcode1
src/third_party/vtune/v8vtune.gyp:1: # Copyright 2012 the V8 project
authors. All rights reserved.
nit: 2013
https://codereview.chromium.org/11574031/diff/99001/src/third_party/vtune/v8vtune.gyp#newcode31
src/third_party/vtune/v8vtune.gyp:31: 'console%': '',
I don't see what you need this for.
https://codereview.chromium.org/11574031/diff/99001/src/third_party/vtune/v8vtune.gyp#newcode41
src/third_party/vtune/v8vtune.gyp:41: '../../../src',
I don't think you need this either, since you have the full path to v8.h
at the place where you #include it. Does the build work when you remove
this 'include_dirs+' section? (You'll probably have to update
vtune-jit.cc to include the vtune-related headers without paths.)
https://codereview.chromium.org/11574031/diff/99001/src/third_party/vtune/v8vtune.gyp#newcode44
src/third_party/vtune/v8vtune.gyp:44:
'../../../src/third_party/vtune/ittnotify_config.h',
I don't think there's a need for this weird path specification. Since
the files are in the same directory as this .gyp file, you can just list
them without path.
https://codereview.chromium.org/11574031/diff/99001/src/third_party/vtune/v8vtune.gyp#newcode54
src/third_party/vtune/v8vtune.gyp:54: 'toolsets': ['host', 'target'],
Why would you want to build the vtune lib for the host toolset?
https://codereview.chromium.org/11574031/diff/99001/src/third_party/vtune/v8vtune.gyp#newcode60
src/third_party/vtune/v8vtune.gyp:60: 'BUILDING_V8_SHARED',
As far as I can see you're not using either of these defines. So why
define them?
https://codereview.chromium.org/11574031/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
