On 2013/03/12 12:37:27, Hannes Payer wrote:
https://codereview.chromium.org/12314155/diff/30036/src/ia32/macro-assembler-ia32.cc
File src/ia32/macro-assembler-ia32.cc (right):
https://codereview.chromium.org/12314155/diff/30036/src/ia32/macro-assembler-ia32.cc#newcode1217
src/ia32/macro-assembler-ia32.cc:1217: ExternalReference allocation_top =
((flags & PRETENURE) != 0) ?
On 2013/03/12 11:28:20, danno wrote:
> Does it make sense to create two utility functions:
>
> GetAllocationTopReference()
> GetAllocationLimitReference()
>
> That take flags and return ExternalReferences? You use this in multiple
places,
> and it will become even more useful when you add old data space support.
Done.
https://codereview.chromium.org/12314155/diff/30036/src/macro-assembler.h
File src/macro-assembler.h (right):
https://codereview.chromium.org/12314155/diff/30036/src/macro-assembler.h#newcode54
src/macro-assembler.h:54: PRETENURE = 1 << 4
On 2013/03/12 11:28:20, danno wrote:
> Do you think it makes sense to call this PRETENURE_OLD_POINTER_SPACE?
>
Done.
I created a class AllocationUtils in macro-assembler.h which provides
GetAllocationTopReference() and GetAllocationLimitReference().
https://codereview.chromium.org/12314155/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
