lgtm
https://codereview.chromium.org/12314155/diff/43001/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):
https://codereview.chromium.org/12314155/diff/43001/src/arm/macro-assembler-arm.cc#newcode1641
src/arm/macro-assembler-arm.cc:1641: ((flags & DOUBLE_ALIGNMENT) != 0))
{
Is this really right? Don't you want to ASSERT instead?
https://codereview.chromium.org/12314155/diff/43001/src/macro-assembler.h
File src/macro-assembler.h (right):
https://codereview.chromium.org/12314155/diff/43001/src/macro-assembler.h#newcode172
src/macro-assembler.h:172:
tiny nit: two empty lines before and after?
https://codereview.chromium.org/12314155/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
