The change looks good overall.
https://codereview.chromium.org/13818012/diff/3001/src/arguments.h
File src/arguments.h (right):
https://codereview.chromium.org/13818012/diff/3001/src/arguments.h#newcode122
src/arguments.h:122: Type Name(int argslength, Object** argsobject,
Isolate* isolate) { \
Nit: args_length, args_object would be better.
https://codereview.chromium.org/13818012/diff/3001/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/13818012/diff/3001/src/builtins.cc#newcode132
src/builtins.cc:132: int arglength, Object** argobject, Isolate*
isolate) { \
Nit: args_length, args_object would be better.
https://codereview.chromium.org/13818012/diff/3001/src/builtins.cc#newcode148
src/builtins.cc:148: name##ArgumentsType args(arglength, argobject);
\
This makes builtin calls more expensive. I am running benchmarks to see
the impact.
https://codereview.chromium.org/13818012/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
