NOTE: I am seeing a "TIMEOUT" test failure for arm.check
cctest/testapi/Threading1. I see this with or without this CL, so I'm
assuming
it has nothing to do with my changes.
I'm also seeing some problems with the pre-submit checks that run with
foo.check. That might actually be my problem, although I don't yet
understand
it.
On 2013/04/10 16:53:28, Brad Chen wrote:
Thanks for the comments. I'll upload a minor update after a little bit of
local
testing.
https://codereview.chromium.org/13818012/diff/3001/src/arguments.h
File src/arguments.h (right):
https://codereview.chromium.org/13818012/diff/3001/src/arguments.h#newcode122
src/arguments.h:122: Type Name(int argslength, Object** argsobject,
Isolate*
isolate) { \
On 2013/04/10 14:19:20, ulan wrote:
> Nit: args_length, args_object would be better.
Done.
https://codereview.chromium.org/13818012/diff/3001/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/13818012/diff/3001/src/builtins.cc#newcode132
src/builtins.cc:132: int arglength, Object** argobject, Isolate* isolate)
{ \
On 2013/04/10 14:19:20, ulan wrote:
> Nit: args_length, args_object would be better.
Done.
https://codereview.chromium.org/13818012/diff/3001/src/builtins.cc#newcode148
src/builtins.cc:148: name##ArgumentsType args(arglength, argobject);
\
This is helpful. I haven't done any performance testing of this CL. I
know the
NaCl versions will be incredibly slow.
On 2013/04/10 14:19:20, ulan wrote:
> This makes builtin calls more expensive. I am running benchmarks to see
the
> impact.
https://codereview.chromium.org/13818012/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
