LGTM. I didn't get any presubmit errors. I will land after Jakob's review.

On my machine this CL seems to be performance neutral on Octane and Sunspider:

                               benchmark:    score |  tot-oct |      %
===================================================+==========+========
                                Richards:  14844.1 |  14835.8 |    0.1
                               DeltaBlue:  19079.4 |  19257.1 |   -0.9
                                  Crypto:  18723.1 |  18725.9 |   -0.0
                                RayTrace:  19431.7 |  19538.4 |   -0.5
                             EarleyBoyer:  30608.9 |  30630.1 |   -0.1
                                  RegExp:   4286.6 |   4283.0 |    0.1
                                   Splay:   5090.7 |   5093.9 |   -0.1
                            NavierStokes:  19155.3 |  19140.6 |    0.1
                                   PdfJS:  14752.0 |  14593.4 |    1.1
                                Mandreel:  15092.0 |  15175.7 |   -0.6
                                 Gameboy:  20865.4 |  20902.9 |   -0.2
                                CodeLoad:  16330.3 |  15902.9 |    2.7
                                   Box2D:  14565.2 |  14523.4 |    0.3
                                  Octane:  14683.1 |  14663.1 |    0.1
---------------------------------------------------+----------+--------

                               benchmark:    score |      tot |      %
===================================================+==========+========
                                 3d-cube:     14.0 |     13.9 |   -0.7
                                3d-morph:      9.1 |      9.0 |   -1.1
                             3d-raytrace:     14.1 |     14.0 |   -0.7
                     access-binary-trees:      2.2 |      2.2 |
                         access-fannkuch:      7.5 |      7.6 |    1.3
                            access-nbody:      5.5 |      5.6 |    1.8
                           access-nsieve:      3.7 |      3.8 |    2.7
                bitops-3bit-bits-in-byte:      0.6 |      0.7 |   16.7
                     bitops-bits-in-byte:      4.3 |      4.4 |    2.3
                      bitops-bitwise-and:      3.0 |      3.1 |    3.3
                      bitops-nsieve-bits:      4.1 |      4.1 |
                   controlflow-recursive:      2.0 |      2.0 |
                              crypto-aes:      9.6 |      9.4 |   -2.1
                              crypto-md5:      4.5 |      4.5 |
                             crypto-sha1:      5.3 |      5.2 |   -1.9
                       date-format-tofte:     11.5 |     11.1 |   -3.5
                       date-format-xparb:     10.1 |     10.0 |   -1.0
                             math-cordic:      2.4 |      2.8 |   16.7
                       math-partial-sums:      9.8 |      9.6 |   -2.0
                      math-spectral-norm:      3.0 |      3.0 |
                              regexp-dna:      7.8 |      7.7 |   -1.3
                           string-base64:      5.9 |      5.9 |
                            string-fasta:      8.0 |      8.0 |
                         string-tagcloud:     23.6 |     24.0 |    1.7
                      string-unpack-code:     24.3 |     24.7 |    1.6
                   string-validate-input:      9.8 |     10.0 |    2.0
                          SunSpider-Once:    205.7 |    206.3 |    0.3
---------------------------------------------------+----------+--------



https://codereview.chromium.org/13818012/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to