Thanks for comments!
I moved SetObjectGroupId and AddImplicitReference to Isolate, and
SetRetainedObjectInfo to HeapProfiler.
https://codereview.chromium.org/14007008/diff/22001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/14007008/diff/22001/include/v8.h#newcode147
include/v8.h:147: // Generic-purpose unique identifier.
On 2013/04/22 11:34:51, Michael Starzinger wrote:
nit: Can we turn that into a Doxygen comment (i.e. double-asterisk and
multi-line). Also two empty new-lines in front of the comment.
Done.
https://codereview.chromium.org/14007008/diff/22001/include/v8.h#newcode3549
include/v8.h:3549: static void SetObjectGroupId(Isolate* isolate,
On 2013/04/22 12:10:43, Yury Semikhatsky wrote:
Since these methods are new why not make them instance methods on
Isolate?
Done.
https://codereview.chromium.org/14007008/diff/22001/include/v8.h#newcode3553
include/v8.h:3553: static void SetRetainedObjectInfo(Isolate* isolate,
On 2013/04/22 12:05:46, Yury Semikhatsky wrote:
As discussed offline, this method should be on v8::HeapProfiler
Done.
https://codereview.chromium.org/14007008/diff/22001/src/global-handles.cc
File src/global-handles.cc (right):
https://codereview.chromium.org/14007008/diff/22001/src/global-handles.cc#newcode37
src/global-handles.cc:37: #define OBJECT_GROUP_CONNECTIONS_CAPACITY 20
On 2013/04/22 11:34:51, Michael Starzinger wrote:
Make this a "static const int kObjectGroupConntectionsCapacity" in the
private
section within the GlobalHandles class.
Done.
https://codereview.chromium.org/14007008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
