Name suggestions sg.
https://codereview.chromium.org/14007008/diff/29001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/14007008/diff/29001/include/v8.h#newcode3158
include/v8.h:3158: void AddImplicitReference(UniqueId id,
On 2013/04/22 14:39:54, Yury Semikhatsky wrote:
Method name is a bit confusing. May be SetReferenceFromGroup?
SetObjectGroupId
actually adds bidirectional reference while AddImplicitReference adds
unidirectional one. Method names should probably reflect this.
Done.
https://codereview.chromium.org/14007008/diff/29001/src/global-handles.h
File src/global-handles.h (right):
https://codereview.chromium.org/14007008/diff/29001/src/global-handles.h#newcode88
src/global-handles.h:88: // For internal bookeeping.
On 2013/04/22 14:39:54, Yury Semikhatsky wrote:
typo: bookkeeping
Done.
https://codereview.chromium.org/14007008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
