LGTM with nits. I'll land this as soon as Yury gave his OK.
https://codereview.chromium.org/14007008/diff/39001/src/global-handles.cc
File src/global-handles.cc (right):
https://codereview.chromium.org/14007008/diff/39001/src/global-handles.cc#newcode442
src/global-handles.cc:442: const int
GlobalHandles::kObjectGroupConnectionsCapacity = 20;
Can we move the value into the header? I don't think it has to belong to
particular unit of compilation for "static const" fields.
https://codereview.chromium.org/14007008/diff/39001/src/global-handles.cc#newcode452
src/global-handles.cc:452:
object_group_connections_(kObjectGroupConnectionsCapacity) {}
The retainer_infos_ and the implicit_ref_connections_ list should be
initialized here explicitly as well.
https://codereview.chromium.org/14007008/diff/39001/src/global-handles.cc#newcode914
src/global-handles.cc:914:
nit: Two empty new-lines between functions.
https://codereview.chromium.org/14007008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
