Thanks for review!
https://codereview.chromium.org/14007008/diff/51001/test/cctest/test-heap-profiler.cc
File test/cctest/test-heap-profiler.cc (right):
https://codereview.chromium.org/14007008/diff/51001/test/cctest/test-heap-profiler.cc#newcode1212
test/cctest/test-heap-profiler.cc:1212:
isolate_->SetReference(v8::Persistent<v8::Object>::Cast(objects_[0]),
On 2013/04/24 14:21:24, Yury Semikhatsky wrote:
Can you also add a test for the references provided via
SetReferenceFromGroup
call from a one-object group to make sure heap profiler will handle it
properly?
Offline discussion: references from an one-object object group are
converted into the same format than references from an object.
test-global-handles/ImplicitReferences tests this. So from the heap
profiler point of view, it shouldn't make a difference. However, I made
one of these references to be from an one-object object group.
https://codereview.chromium.org/14007008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
