On 2013/06/11 07:36:20, dcarney wrote:
I looked over it more, and it seems like you could move the entirety of
your
new
code into CallApiFunctionAndReturn. I don't understand why you're not
profiling
the other callsite anyway. It would only be a couple of additional
instructions
there, which could be deferred to the end of CallApiFunctionAndReturn
I was going to do this later as part of supporting profiling of API function
calls. At the moment arguments for the call are prepared by callers of
CallApiFunctionAndReturn. If we want in some cases to pass one additional
parameter in CallApiFunctionAndReturn that means the caller should be aware
of
that and adjust PrepareCallApiFunction call accordingly to allow passing one
more param, otherwise CallApiFunctionAndReturn could have to rearrange stack
values to add one more param. This can probably be solved by making
PrepareCallApiFunction provisionally allocate one more slot to fit the
optional
parameter leaving its call sites unchanged, is that what you suggest?
https://codereview.chromium.org/16286016/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
