lgtm

you need to trigger all the cases in tests.
specifically, two tests, test-api/FunctionTemplate and test-api/SimpleCallback should have an outer loop that runs the contents once with the profiling flag
enabled and once without
the function CheckReturnValue should be modified to check that the vmstate is
correct when the profiling flag is on

https://codereview.chromium.org/16286016/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to