LGTM with 2 style nits when Dan's feedback is addressed.
https://chromiumcodereview.appspot.com/16286016/diff/68001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://chromiumcodereview.appspot.com/16286016/diff/68001/test/cctest/test-api.cc#newcode1000
test/cctest/test-api.cc:1000: bool is_profiling = i;
Nit: Use 'i > 0', implicit conversions from int to bool are bad style
and more often than not an error.
https://chromiumcodereview.appspot.com/16286016/diff/68001/test/cctest/test-api.cc#newcode1071
test/cctest/test-api.cc:1071: bool is_profiling = i;
Same here.
https://chromiumcodereview.appspot.com/16286016/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
