https://codereview.chromium.org/16109010/diff/1/src/atomicops_internals_arm_gcc.h
File src/atomicops_internals_arm_gcc.h (right):
https://codereview.chromium.org/16109010/diff/1/src/atomicops_internals_arm_gcc.h#newcode96
src/atomicops_internals_arm_gcc.h:96: " teq %0, %4\n"
cmp %0, %4 is more readable here.
https://codereview.chromium.org/16109010/diff/1/src/atomicops_internals_arm_gcc.h#newcode104
src/atomicops_internals_arm_gcc.h:104: } while (reloop != 0);
You didn't execute clrex when the cmp failed (not mandatory but nice to
have)
https://codereview.chromium.org/16109010/diff/1/src/atomicops_internals_arm_gcc.h#newcode161
src/atomicops_internals_arm_gcc.h:161: // fail = STREX(ptr, new_value)
nit: reloop = STREX(ptr, new_value)
https://codereview.chromium.org/16109010/diff/1/src/atomicops_internals_arm_gcc.h#newcode172
src/atomicops_internals_arm_gcc.h:172: #elif defined(__ARM_ARCH_5__) ||
defined(__ARM_ARCH_5T__) || \
V8 requires ARMv6 as a baseline, you don't need this code.
https://codereview.chromium.org/16109010/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
