https://codereview.chromium.org/17858002/diff/14001/src/arm/codegen-arm.cc
File src/arm/codegen-arm.cc (right):
https://codereview.chromium.org/17858002/diff/14001/src/arm/codegen-arm.cc#newcode115
src/arm/codegen-arm.cc:115: #if defined(V8_HOST_ARCH_ARM) && defined
(V8_HOST_CAN_READ_UNALIGNED)
It looks like V8_HOST_CAN_READ_UNALIGNED (which is set to 1 for armv7)
doesn't imply that the arch supports unaligned fp accesses.
I am getting "bus error" when running this cctest on Android devices:
cctest --nocrankshaft test-utils/MemMove --nobreak-on-abort
--nodead-code-elimination --nofold-constants
https://codereview.chromium.org/17858002/diff/14001/src/arm/disasm-arm.cc
File src/arm/disasm-arm.cc (right):
https://codereview.chromium.org/17858002/diff/14001/src/arm/disasm-arm.cc#newcode446
src/arm/disasm-arm.cc:446: ":%d", (1<<align)<<6);
Spaces around "<<".
https://codereview.chromium.org/17858002/diff/14001/src/platform.h
File src/platform.h (right):
https://codereview.chromium.org/17858002/diff/14001/src/platform.h#newcode380
src/platform.h:380: const uint8_t* src,
Indentation is off.
https://codereview.chromium.org/17858002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
