LGTM with nits.
https://chromiumcodereview.appspot.com/17858002/diff/25001/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):
https://chromiumcodereview.appspot.com/17858002/diff/25001/src/arm/assembler-arm.cc#newcode398
src/arm/assembler-arm.cc:398: switch (align) {
Extracting this switch into a function would avoid code duplication
below.
https://chromiumcodereview.appspot.com/17858002/diff/25001/src/arm/assembler-arm.cc#newcode1832
src/arm/assembler-arm.cc:1832: void Assembler::pld(const MemOperand&
address) {
Missing the description comment.
https://chromiumcodereview.appspot.com/17858002/diff/25001/src/arm/codegen-arm.cc
File src/arm/codegen-arm.cc (right):
https://chromiumcodereview.appspot.com/17858002/diff/25001/src/arm/codegen-arm.cc#newcode137
src/arm/codegen-arm.cc:137: Label loop, less_256, less_128, less_64,
less_32, _16_or_less, _8_or_less;
The main loop copies 64 byte at a time. Why don't we prefetch 64 bytes?
Or does prefetching by more make big performance difference?
https://chromiumcodereview.appspot.com/17858002/diff/25001/src/arm/codegen-arm.cc#newcode173
src/arm/codegen-arm.cc:173: __ pld(MemOperand(src, 256));
Shouldn't this be __ pld(MemOperand(src, 256 - 32)) since src advanced
by 64?
https://chromiumcodereview.appspot.com/17858002/diff/25001/src/v8utils.h
File src/v8utils.h (right):
https://chromiumcodereview.appspot.com/17858002/diff/25001/src/v8utils.h#newcode431
src/v8utils.h:431: memcpy(dest, src, 15);
OK, if this gives perf. improvement compared to memcpy(dest, src,
chars).
https://chromiumcodereview.appspot.com/17858002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
