https://chromiumcodereview.appspot.com/17858002/diff/14001/src/arm/disasm-arm.cc
File src/arm/disasm-arm.cc (right):
https://chromiumcodereview.appspot.com/17858002/diff/14001/src/arm/disasm-arm.cc#newcode446
src/arm/disasm-arm.cc:446: ":%d", (1<<align)<<6);
On 2013/06/28 15:07:43, ulan wrote:
Spaces around "<<".
Done.
https://chromiumcodereview.appspot.com/17858002/diff/14001/src/platform.h
File src/platform.h (right):
https://chromiumcodereview.appspot.com/17858002/diff/14001/src/platform.h#newcode380
src/platform.h:380: const uint8_t* src,
On 2013/06/28 15:07:43, ulan wrote:
Indentation is off.
Done.
https://chromiumcodereview.appspot.com/17858002/diff/25001/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):
https://chromiumcodereview.appspot.com/17858002/diff/25001/src/arm/assembler-arm.cc#newcode398
src/arm/assembler-arm.cc:398: switch (align) {
On 2013/07/09 15:16:32, ulan wrote:
Extracting this switch into a function would avoid code duplication
below.
Done.
https://chromiumcodereview.appspot.com/17858002/diff/25001/src/arm/assembler-arm.cc#newcode1832
src/arm/assembler-arm.cc:1832: void Assembler::pld(const MemOperand&
address) {
On 2013/07/09 15:16:32, ulan wrote:
Missing the description comment.
Done.
https://chromiumcodereview.appspot.com/17858002/diff/25001/src/arm/codegen-arm.cc
File src/arm/codegen-arm.cc (right):
https://chromiumcodereview.appspot.com/17858002/diff/25001/src/arm/codegen-arm.cc#newcode137
src/arm/codegen-arm.cc:137: Label loop, less_256, less_128, less_64,
less_32, _16_or_less, _8_or_less;
With ARM, pld starts a load but doesn't wait for the result. If we only
preload 64 bytes, it wouldn't speedup anything because we would do the
load just after the preload (in fact in would add a little overhead). We
need a preload of 256 to have the best result.
However, loading too much data would slowdown. That why we try to
preload exactly what we need (we only preload up to 63 extra bytes).
https://chromiumcodereview.appspot.com/17858002/diff/25001/src/arm/codegen-arm.cc#newcode173
src/arm/codegen-arm.cc:173: __ pld(MemOperand(src, 256));
On 2013/07/09 15:16:32, ulan wrote:
Shouldn't this be __ pld(MemOperand(src, 256 - 32)) since src advanced
by 64?
Done.
https://chromiumcodereview.appspot.com/17858002/diff/25001/src/v8utils.h
File src/v8utils.h (right):
https://chromiumcodereview.appspot.com/17858002/diff/25001/src/v8utils.h#newcode431
src/v8utils.h:431: memcpy(dest, src, 15);
This gives good improvement. For small known sizes, gcc generates the
good instructions (ldrb, ldrh, ldr) to copy the needed size.
https://chromiumcodereview.appspot.com/17858002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
