https://codereview.chromium.org/16925008/diff/81001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/16925008/diff/81001/src/code-stubs.h#newcode541
src/code-stubs.h:541: }
"}" fits in the previous line.
https://codereview.chromium.org/16925008/diff/81001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/16925008/diff/81001/src/hydrogen-instructions.cc#newcode2207
src/hydrogen-instructions.cc:2207: bool boolean_value)
As discussed offline, is_cell can be passed in paramters as other flags.
https://codereview.chromium.org/16925008/diff/81001/src/stub-cache.cc
File src/stub-cache.cc (right):
https://codereview.chromium.org/16925008/diff/81001/src/stub-cache.cc#newcode522
src/stub-cache.cc:522: code->ReplaceNthObject(1, *cell_map, *cell);
I didn't get this part. Where in the generated code does
isolate_->heap()->global_property_cell_map() appear? And shouldn't the
second argument be cell->map()?
https://codereview.chromium.org/16925008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
