https://codereview.chromium.org/16925008/diff/118002/src/x64/lithium-gap-resolver-x64.cc
File src/x64/lithium-gap-resolver-x64.cc (right):

https://codereview.chromium.org/16925008/diff/118002/src/x64/lithium-gap-resolver-x64.cc#newcode214
src/x64/lithium-gap-resolver-x64.cc:214: __ push(Immediate(upper));
It seems that this code is not correct for X64 and not caught by the
current tests.

Why not:
  __movq(kScratchRegister, int_val, RelocInfo::NONE64);
  __movq(dst, kScratchRegister);

I rebased X32 port with master, reviewed the code changes for X64 and
found out this issue.

https://codereview.chromium.org/16925008/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to