Feedback addressed, please take another look.
https://codereview.chromium.org/16925008/diff/81001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/16925008/diff/81001/src/code-stubs.h#newcode541
src/code-stubs.h:541: }
On 2013/07/01 11:35:03, ulan wrote:
"}" fits in the previous line.
Done.
https://codereview.chromium.org/16925008/diff/81001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/16925008/diff/81001/src/hydrogen-instructions.cc#newcode2207
src/hydrogen-instructions.cc:2207: bool boolean_value)
On 2013/07/01 11:35:03, ulan wrote:
As discussed offline, is_cell can be passed in paramters as other
flags.
Done.
https://codereview.chromium.org/16925008/diff/81001/src/stub-cache.cc
File src/stub-cache.cc (right):
https://codereview.chromium.org/16925008/diff/81001/src/stub-cache.cc#newcode522
src/stub-cache.cc:522: code->ReplaceNthObject(1, *cell_map, *cell);
On 2013/07/01 11:35:03, ulan wrote:
I didn't get this part. Where in the generated code does
isolate_->heap()->global_property_cell_map() appear? And shouldn't the
second
argument be cell->map()?
The idea behind code templates is that you create a template with
dummy/placeholder objects with maps that are specific enough to uniquely
distinguish the object from others embedded in the code. When the
template is instantiated, the code is copied, and these placeholder
objects get replaced with the "real" values needed by the specialized
code template
What these two ReplaceNthObject mean is "find the first placeholder map
(i.e. the first object that has the map "meta map") and replace it with
the receiver map, then find the first placeholder cell (i.e. the first
object with the cell_map) and replace it with the real cell we use.
https://codereview.chromium.org/16925008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
