Another round of comments. I have to look into the platform ports in more detail.
https://codereview.chromium.org/15094018/diff/52061/src/arm/ic-arm.cc File src/arm/ic-arm.cc (right): https://codereview.chromium.org/15094018/diff/52061/src/arm/ic-arm.cc#newcode1234 src/arm/ic-arm.cc:1234: FAST_DOUBLE_ELEMENTS); indent https://codereview.chromium.org/15094018/diff/52061/src/arm/ic-arm.cc#newcode1257 src/arm/ic-arm.cc:1257: FAST_ELEMENTS); indent https://codereview.chromium.org/15094018/diff/52061/src/arm/ic-arm.cc#newcode1388 src/arm/ic-arm.cc:1388: FAST_DOUBLE_ELEMENTS); indent https://codereview.chromium.org/15094018/diff/52061/src/code-stubs-hydrogen.cc File src/code-stubs-hydrogen.cc (right): https://codereview.chromium.org/15094018/diff/52061/src/code-stubs-hydrogen.cc#newcode434 src/code-stubs-hydrogen.cc:434: HAllocate::Flags flags = HAllocate::CAN_ALLOCATE_IN_NEW_SPACE; We could do that right away. https://codereview.chromium.org/15094018/diff/52061/src/code-stubs-hydrogen.cc#newcode451 src/code-stubs-hydrogen.cc:451: /* This seems to be not finished. https://codereview.chromium.org/15094018/diff/52061/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/15094018/diff/52061/src/heap.cc#newcode2885 src/heap.cc:2885: } why do you need that scope? https://codereview.chromium.org/15094018/diff/52061/src/heap.cc#newcode4497 src/heap.cc:4497: allocation_site); Can you move AllocateWithAllocationSite into a new line and make the layout consistent with the following Allocate*WithAllocationsSite calls? https://codereview.chromium.org/15094018/diff/52061/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/15094018/diff/52061/src/hydrogen.cc#newcode1690 src/hydrogen.cc:1690: HValue* alloc_site) { I think we should assert that alloc_site is not Handle<Object>::null(). https://codereview.chromium.org/15094018/diff/52061/src/hydrogen.cc#newcode5549 src/hydrogen.cc:5549: isolate()); indent https://codereview.chromium.org/15094018/diff/52061/src/hydrogen.cc#newcode5561 src/hydrogen.cc:5561: // AllocationSite from the full code gen Is the uncommented code still needed? What about the comment about copying useful information? https://codereview.chromium.org/15094018/diff/52061/src/x64/ic-x64.cc File src/x64/ic-x64.cc (right): https://codereview.chromium.org/15094018/diff/52061/src/x64/ic-x64.cc#newcode677 src/x64/ic-x64.cc:677: FAST_DOUBLE_ELEMENTS); indent https://codereview.chromium.org/15094018/diff/52061/src/x64/ic-x64.cc#newcode1622 src/x64/ic-x64.cc:1622: FAST_DOUBLE_ELEMENTS); indent https://codereview.chromium.org/15094018/diff/52061/src/x64/ic-x64.cc#newcode1647 src/x64/ic-x64.cc:1647: FAST_ELEMENTS); indent https://codereview.chromium.org/15094018/ -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
