LGTM! Just minor nits.
https://codereview.chromium.org/15094018/diff/71001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
https://codereview.chromium.org/15094018/diff/71001/src/arm/code-stubs-arm.cc#newcode4669
src/arm/code-stubs-arm.cc:4669: */
It looks like that all comments in that file are of style
// foo
// bar
Let's continue doing that.
https://codereview.chromium.org/15094018/diff/71001/src/arm/code-stubs-arm.cc#newcode4679
src/arm/code-stubs-arm.cc:4679: // sentinels
This comment can be removed.
https://codereview.chromium.org/15094018/diff/71001/src/arm/code-stubs-arm.cc#newcode7220
src/arm/code-stubs-arm.cc:7220:
Can we add there a comment?
https://codereview.chromium.org/15094018/diff/71001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/15094018/diff/71001/src/ia32/code-stubs-ia32.cc#newcode4715
src/ia32/code-stubs-ia32.cc:4715: */
It looks like that all comments in that file are of style
// foo
// bar
Let's continue doing that.
https://codereview.chromium.org/15094018/diff/71001/src/ia32/code-stubs-ia32.cc#newcode4724
src/ia32/code-stubs-ia32.cc:4724: // sentinels
This comment can be removed.
https://codereview.chromium.org/15094018/diff/71001/src/ia32/code-stubs-ia32.cc#newcode7819
src/ia32/code-stubs-ia32.cc:7819:
Can we add there a comment?
https://codereview.chromium.org/15094018/diff/71001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):
https://codereview.chromium.org/15094018/diff/71001/src/x64/code-stubs-x64.cc#newcode3754
src/x64/code-stubs-x64.cc:3754: */
It looks like that all comments in that file are of style
// foo
// bar
Let's continue doing that.
https://codereview.chromium.org/15094018/diff/71001/src/x64/code-stubs-x64.cc#newcode3763
src/x64/code-stubs-x64.cc:3763: // sentinels
This comment can be removed.
https://codereview.chromium.org/15094018/diff/71001/src/x64/code-stubs-x64.cc#newcode6795
src/x64/code-stubs-x64.cc:6795:
Can we add there a comment?
https://codereview.chromium.org/15094018/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
