thanks Hannes, getting cleaner now!
--Michael
https://codereview.chromium.org/15094018/diff/52061/src/arm/ic-arm.cc
File src/arm/ic-arm.cc (right):
https://codereview.chromium.org/15094018/diff/52061/src/arm/ic-arm.cc#newcode1234
src/arm/ic-arm.cc:1234: FAST_DOUBLE_ELEMENTS);
On 2013/07/03 15:26:45, Hannes Payer wrote:
indent
Done.
https://codereview.chromium.org/15094018/diff/52061/src/arm/ic-arm.cc#newcode1257
src/arm/ic-arm.cc:1257: FAST_ELEMENTS);
On 2013/07/03 15:26:45, Hannes Payer wrote:
indent
Done.
https://codereview.chromium.org/15094018/diff/52061/src/arm/ic-arm.cc#newcode1388
src/arm/ic-arm.cc:1388: FAST_DOUBLE_ELEMENTS);
On 2013/07/03 15:26:45, Hannes Payer wrote:
indent
Done.
https://codereview.chromium.org/15094018/diff/52061/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/15094018/diff/52061/src/code-stubs-hydrogen.cc#newcode434
src/code-stubs-hydrogen.cc:434: HAllocate::Flags flags =
HAllocate::CAN_ALLOCATE_IN_NEW_SPACE;
On 2013/07/03 15:26:45, Hannes Payer wrote:
We could do that right away.
Done.
https://codereview.chromium.org/15094018/diff/52061/src/code-stubs-hydrogen.cc#newcode451
src/code-stubs-hydrogen.cc:451: /*
On 2013/07/03 15:26:45, Hannes Payer wrote:
This seems to be not finished.
I kept the TODO, and altered it to say come back in the next CL and add
an HAssert instruction (need to add this) to verify that the input cell
is really a Cell.
https://codereview.chromium.org/15094018/diff/52061/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/15094018/diff/52061/src/heap.cc#newcode2885
src/heap.cc:2885: }
On 2013/07/03 15:26:45, Hannes Payer wrote:
why do you need that scope?
No reason! Removed :).
https://codereview.chromium.org/15094018/diff/52061/src/heap.cc#newcode4497
src/heap.cc:4497: allocation_site);
On 2013/07/03 15:26:45, Hannes Payer wrote:
Can you move AllocateWithAllocationSite into a new line and make the
layout
consistent with the following Allocate*WithAllocationsSite calls?
I *think* I got what you mean. I changed the indentation for
allocation_site to be 4 spaces in on line 4497. Holler over to me if
more is needed, thanks!
https://codereview.chromium.org/15094018/diff/52061/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/15094018/diff/52061/src/hydrogen.cc#newcode1690
src/hydrogen.cc:1690: HValue* alloc_site) {
On 2013/07/03 15:26:45, Hannes Payer wrote:
I think we should assert that alloc_site is not
Handle<Object>::null().
good idea, but I'll just check for a NULL pointer since it's an HValue.
https://codereview.chromium.org/15094018/diff/52061/src/hydrogen.cc#newcode5561
src/hydrogen.cc:5561: // AllocationSite from the full code gen
On 2013/07/03 15:26:45, Hannes Payer wrote:
Is the uncommented code still needed? What about the comment about
copying
useful information?
Okay, I went ahead and removed this block, I realized it doesn't make
sense. The deal is that if we came in here, we have apparently never
created the boilerplate, so it means we never created the AllocationSite
either. For some reason I had this idea that we did create one before
and now had to copy information out of it. Weird :p.
https://codereview.chromium.org/15094018/diff/52061/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/15094018/diff/52061/src/objects.h#newcode7510
src/objects.h:7510: bool site_is_valid() { return
allocation_site()->IsAllocationSite(); }
On 2013/07/03 15:34:02, Hannes Payer wrote:
this is not a real getter.
Done.
https://codereview.chromium.org/15094018/diff/52061/src/objects.h#newcode7511
src/objects.h:7511: AllocationSite* allocation_site_casted() {
On 2013/07/03 15:34:02, Hannes Payer wrote:
This is also not a real getter. Moreover can we call it
DependingAllocationSite() or something like that.
Done.
https://codereview.chromium.org/15094018/diff/52061/src/x64/ic-x64.cc
File src/x64/ic-x64.cc (right):
https://codereview.chromium.org/15094018/diff/52061/src/x64/ic-x64.cc#newcode677
src/x64/ic-x64.cc:677: FAST_DOUBLE_ELEMENTS);
On 2013/07/03 15:26:45, Hannes Payer wrote:
indent
Done.
https://codereview.chromium.org/15094018/diff/52061/src/x64/ic-x64.cc#newcode1622
src/x64/ic-x64.cc:1622: FAST_DOUBLE_ELEMENTS);
On 2013/07/03 15:26:45, Hannes Payer wrote:
indent
Done.
https://codereview.chromium.org/15094018/diff/52061/src/x64/ic-x64.cc#newcode1647
src/x64/ic-x64.cc:1647: FAST_ELEMENTS);
On 2013/07/03 15:26:45, Hannes Payer wrote:
indent
Done.
https://codereview.chromium.org/15094018/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
