Comment #26 on issue 2741 by [email protected]: max_opt_count is
implemented using the wrong kind of limit
http://code.google.com/p/v8/issues/detail?id=2741
This is the 4th patch you've produced that is not useful. The changes
you're observing on Octane must have some other reason. Here's why:
The first change you're making adds "&& (ic_state != POLYMORPHIC ||
ic_state != MEGAMORPHIC)" to an existing condition. Without even looking at
the surrounding code or knowing anything about V8, it is obvious that this
added condition is always true, because ic_state can't possibly be
POLYMORPHIC and MEGAMORPHIC at the same time. In addition, as I've told you
before, a function's code object doesn't have an ic_state, so checking for
any value of it is pointless either way.
The second change you're making is to Runtime_ClearFunctionTypeFeedback.
That function is only ever called for tests, it is not available to regular
JS code and not part of V8's internal mechanisms. Also, changing how it
works defeats its purpose -- it is supposed to reset a function's type
feedback to pristine state, to be used for testing.
I think it is time to end this conversation. V8 is not the right place for
learning how to program, and that includes learning how to verify that
changes are actually making a difference. You are of course free to
continue to experiment on your own (I wish you lots of fun and an
interesting learning experience!), and you are also most welcome to
contribute another patch when you have one that fixes an actual problem. In
the meantime, I think further updating this issue is not a fruitful use of
your time or mine.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
