Comment #19 on issue 2741 by [email protected]: max_opt_count is
implemented using the wrong kind of limit
http://code.google.com/p/v8/issues/detail?id=2741
Hello hello, I've been recompiling a lot over the weekend to try and see
how in the world these combinations interact with each other. I know you
may consider me a little annoying... but so far there are 3 tests I'm
trying in 3 different places, two of them clear the cache and one tries to
re-enable optimization and is the only call-site of that function but it
seems SharedFunctionInfo::TryReenableOptimization likes re-enabling
optimization behind that one callers back. I really need to get a command
line v8 shell built and going to see exactly which things are being
effected since I'm probably just being overkill on this patch I'll attach
for you to look at.
I don't get any regressions when testing things there, but pdf.js on my
machine goes from ~15,000 to ~18,800 (approx 25% speed boost) and depending
on the combination of those pre-conditions I get CodeLoad to go from
~12,000 to ~17,000 (approx 42% speed boost) and these cases are the ones
I'm trying to convey to you since they don't hurt other cases anyway.
So I don't think I'm barking up the wrong tree per-se, and I did have to
find my way around to get access to that ic_state. Without doubt you would
know how to pick those conditions far better than I can without a debug
console to quickly try them with but I've been trying all weekend :).
Try the patch... see for yourself how it effects things even though I'm
being far to generous on the negations, I'd be happy to get any feedback on
which ones to favour since GENERIC seems a little fishy too but it might
just be ok to keep trying to re-optimize a GENERIC case.
Hope you had a nice weekend.
Attachments:
Issue-2741-TestConditions-v1.diff 2.7 KB
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
