On 2013/07/08 11:12:25, danno wrote:
https://codereview.chromium.org/18503006/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/18503006/diff/1/src/hydrogen-instructions.h#newcode5308
src/hydrogen-instructions.h:5308: Representation::Smi() :
Representation::Tagged());
You should probably gate using ::Smi() here and below with the
FLAG_track_fields
flag.
Done.
https://codereview.chromium.org/18503006/diff/1/src/hydrogen-instructions.h#newcode5314
src/hydrogen-instructions.h:5314: Representation::Smi() :
Representation::Tagged());
It's _always_ ::Smi() for FixedArrays, no need to pass in is_fast_elements
Done.
https://codereview.chromium.org/18503006/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/18503006/diff/1/src/hydrogen.cc#newcode1361
src/hydrogen.cc:1361:
HObjectAccess::ForFixedArrayLength(IsFastElementsKind(kind)), capacity);
This is always Smi()
Done.
https://codereview.chromium.org/18503006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
