https://codereview.chromium.org/18503006/diff/8001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (left):
https://codereview.chromium.org/18503006/diff/8001/src/hydrogen-instructions.h#oldcode5802
src/hydrogen-instructions.h:5802: = Representation::Tagged())
nit: start the first parameter "obj" on a new line, that prevents the
funky indentation.
https://codereview.chromium.org/18503006/diff/8001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/18503006/diff/8001/src/hydrogen-instructions.h#newcode5342
src/hydrogen-instructions.h:5342: inline HObjectAccess
WithRepresentation(Representation representation) {
Ouch. I really wish we didn't need this version. If I understand
correctly, this is currently only this way because of the implicit
unboxing of fields in HeapNumbers and for polymorphic access. Is there a
way to make if more specific, e.g. ForHeapNumberBox() without the extra
representation parameter? And do we really need it for polymorphic
access? You can always use the access of the most generic type.
https://codereview.chromium.org/18503006/diff/8001/src/hydrogen-instructions.h#newcode5355
src/hydrogen-instructions.h:5355: static HObjectAccess
ForArrayLength(bool is_fast_elements = false) {
Can you pass in the ElementsKind here? The boolean parameter doesn't
give much context,
https://codereview.chromium.org/18503006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
