https://codereview.chromium.org/18503006/diff/8001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/18503006/diff/8001/src/hydrogen-instructions.h#newcode5355
src/hydrogen-instructions.h:5355: static HObjectAccess
ForArrayLength(bool is_fast_elements = false) {
I would prefer that you use ElementsKind and not have a default at all,
the information about which elements you have is always available. See
below.
On 2013/07/23 15:04:10, titzer wrote:
On 2013/07/16 11:51:58, danno wrote:
> Can you pass in the ElementsKind here? The boolean parameter doesn't
give much
> context,
What would be the default elements kind? We have 3 kinds of uses: ones
where we
don't know (assume tagged), ones where we know (assume smi), and ones
where we
have an elements kind.
https://codereview.chromium.org/18503006/diff/15001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/18503006/diff/15001/src/hydrogen.cc#newcode1095
src/hydrogen.cc:1095: AddStore(object,
HObjectAccess::ForArrayLength(IsFastElementsKind(kind)),
Here just pass 'kind'
https://codereview.chromium.org/18503006/diff/15001/src/hydrogen.cc#newcode1164
src/hydrogen.cc:1164: ? AddLoad(object,
HObjectAccess::ForArrayLength(true), NULL)
Here just pass from_kind
https://codereview.chromium.org/18503006/diff/15001/src/hydrogen.cc#newcode5406
src/hydrogen.cc:5406: HObjectAccess::ForArrayLength());
Here it's map->elements_kind()
https://codereview.chromium.org/18503006/diff/15001/src/hydrogen.cc#newcode5658
src/hydrogen.cc:5658: object, HObjectAccess::ForArrayLength(true),
mapcompare);
And here it's also map->elements_kind()
https://codereview.chromium.org/18503006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
