Too late for this change, but could we pretty please have a solution that
avoids
the proliferation of tiny hydrogen-*.h files that IMO serve no purpose.
I discussed this with Jakob and Sven a couple of weeks ago, where I
suggested
just putting the HGraph::MyPhase methods in different files. We didn't
agree
on
a solution because there were too few datapoints at the time. Now we are
getting
to having more than a dozen such headers. This is worrying.
I think we can get rid of these headers by just putting the
HGraph::MyPhase
methods directly into the hydrogen-my-phase.cc files. Then any auxiliary
classes
and datastructures that are necessary to that phase could be put directly
in
there, without needing to have them in a header--any header. I know it is
not
customary to put the implementation of a C++ class into multiple different
files, but I think in this case it would be manageable if we put a comment
next
to the declaration of the HGraph::MyPhase() method indicating which file
it is
in. This way we avoid a proliferation of tiny, and again, IMO, useless
header
files. For the record, I do not consider "Because C++" a satisfactory
response.
I asked Danno about the two files per phase issue before; he said I should
just
do it, as we're going to put all the compiler related files into a separate
subdirectory. IMHO, we should put all the Hydrogen phases into
hydrogen-phases.{cc,h}. That'd be consistent with
hydrogen-instructions.{cc,h}.
https://codereview.chromium.org/18562009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
