I am OK with the one hydrogen-phases.h file. It shouldn't change too much, and thus it shouldn't cause too many recompilations. Splitting the phases out into their own files has already helped make compilation more incremental.
On Fri, Jul 12, 2013 at 9:56 AM, <[email protected]> wrote: > On 2013/07/11 14:08:34, danno wrote: > >> Ben's observation seems reasonable, the .cc split is fine but the tiny >> headers >> are annoying. I like Jakob's solution, where all of the phases are >> declared >> together but the implementations are split out. >> > > DBC: I do not feel this strongly, but I actually like small headers - it is > really easy to switch between declaration and definition, and having small > headers limits the required recompilation when something changes. My vote > would > be to keep small headers. > > https://codereview.chromium.**org/18562009/<https://codereview.chromium.org/18562009/> > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
