On 2013/07/11 12:27:17, Benedikt Meurer wrote:
I asked Danno about the two files per phase issue before; he said I should
just
do it, as we're going to put all the compiler related files into a
separate
subdirectory. IMHO, we should put all the Hydrogen phases into
hydrogen-phases.{cc,h}. That'd be consistent with
hydrogen-instructions.{cc,h}.
I don't mind those tiny headers. Hopefully we'll rarely have to open them
in an
editor, and if we hide them in src/hydrogen/ their existence wouldn't
bother me.
Yet another suggestion:
src/hydrogen/phases.h <-- #included by hydrogen.cc, defines the public
interface of all phases
src/hydrogen/phase-gvn.cc <-- implementation of just one phase; file names
make
the 1:n coupling of .h/.cc obvious
src/hydrogen/phase-dehoist.cc
etc.
Bonus points if someone comes up with a sensible renaming of the phases so
that
they're executed in alphabetical order :-P
But I'm fine with Ben's suggestion too.
I'd go as far as suggesting that we should split HInstructions'
implementations
across .cc files too:
all the HFoo::RepresentationFromInputs() implementations should be in
hydrogen/infer-representation.cc,
HFoo::Canonicalize() should be in hydrogen/canonicalize.cc, and so on.
https://codereview.chromium.org/18562009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
