PTAL
Now AddIncrementCounter is implemented using the suggested sequence of
HConstant, HLoadKeyed, HAdd and HStoreKeyed. HConstant had to be extended to
handle ExternalReferences. And we had to add an HType::None to type these
constants (as suggested by Michael/Toon).
The amount of code is roughly the same as the initial patch, while at the
same
time the new patch is certainly less efficient and a lot more invasive. In
my
opinion, the HIncrementCounter approach is better, it's easier to
understand and
maintain.
https://codereview.chromium.org/19562003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
