https://codereview.chromium.org/19562003/diff/39001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/19562003/diff/39001/src/hydrogen-instructions.h#newcode5570
src/hydrogen-instructions.h:5570: static HObjectAccess ForInteger32() {
On 2013/07/25 11:56:47, titzer wrote:
Would prefer this to be ForExternalReference() or even ForCounter(),
and pass a
representation. Please add a TODO(titzer) here as well; using
kInobject as the
portion will prevent GVN'ing of in-object accesses past these counter
updates.
We may even want a separate GVN flag in the future.
You need to change the kDependsOn/ChangesSpecializedArrayElements (this
is for external arrays) to kDependsOn/ChangesExternalMemory and have a
new Portion in HObjectAccess called kExternalMemory that forces this
renamed GVN flag to be set appropriately. This is not just for
performance, it's for correctness, since external memory access of
TypedArrays could be to the same memory where the counter is stored
(unlikely, but possible). Even if this doesn't happen in practice now,
as we use ExternalReferences more in Crankshaft code, it's good to have
a sound foundation.
https://codereview.chromium.org/19562003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
