On 2013/07/23 07:00:47, Benedikt Meurer wrote:
Yeah, Michael already convinced me that it's better this way.
https://codereview.chromium.org/19562003/diff/4001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/19562003/diff/4001/src/hydrogen-instructions.h#newcode3289
src/hydrogen-instructions.h:3289: Representation r =
Representation::None());
On 2013/07/22 14:19:55, danno wrote:
> Why None? It seems to make much more sense to use "External", that's
exactly
> what it's for.
Copy'n'paste....
I'm ok with this change as it is, but I think that if you want to do a
direct
load/store in the future, HLoadNamed and HStoreNamed are the right way to
go.
They just can't deal with all the various array element types yet.
https://codereview.chromium.org/19562003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
