Hi Toon,
I find that in KeyedStoreIC::StoreElementStub() we take special care to
ensure
that the store_mode of the IC is always updated in a way that respects the
totality of receiver maps seen thus far. If the IC is polymorphic, then the
store_mode has transition information stripped from it by passing through
the
gate of GetNonTransitioningStoreMode(old_mode). Grow versus not-grow will be
preserved.
So I think the store_mode is safe to use without modification as we built
up the
inlined polymorphic keyed store since it was good enough for each
polymorphic
case in the IC, and adjusted carefully when new information arrived up to
the
crankshaft point.
Thanks,
--Michael
https://codereview.chromium.org/21058003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
