https://codereview.chromium.org/21058003/diff/10001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/21058003/diff/10001/src/hydrogen.cc#newcode5662
src/hydrogen.cc:5662: NULL,
I'm pretty sure that you need to pass |mapcompare| here. Otherwise the
length load can be hoisted past the dispatch, which can crash (when the
code tries to load a JSArray's length from an object that isn't a
JSArray).
https://codereview.chromium.org/21058003/diff/10001/src/hydrogen.cc#newcode5674
src/hydrogen.cc:5674:
ASSERT(IsExternalArrayElementsKind(elements_kind));
AFAICS BuildUncheckedMonomorphicElementAccess can handle external
elements too. So let's remove some more duplication :-)
if (IsDictionaryElementsKind(elements_kind)) {
if (is_store) access = ... else ...
} else {
ASSERT(IsFastElementsKind(...) || IsExternalArrayElementsKind(...));
access = BuildUncheckedMonomorphicElementAccess(...);
}
https://codereview.chromium.org/21058003/diff/10001/test/mjsunit/array-store-and-grow.js
File test/mjsunit/array-store-and-grow.js (right):
https://codereview.chromium.org/21058003/diff/10001/test/mjsunit/array-store-and-grow.js#newcode192
test/mjsunit/array-store-and-grow.js:192: // case.
nit: missing ')' after 'case'
https://codereview.chromium.org/21058003/diff/10001/test/mjsunit/array-store-and-grow.js#newcode210
test/mjsunit/array-store-and-grow.js:210: }());
nit: AFAIK the outer parentheses aren't even necessary, but when we do
put them, we usually put them around the function definition, as in:
(function() {...})();
https://codereview.chromium.org/21058003/diff/10001/test/mjsunit/array-store-and-grow.js#newcode214
test/mjsunit/array-store-and-grow.js:214: // deopt if you pass an
element out of bounds
nit: trailing full stop
https://codereview.chromium.org/21058003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
