Left comments and also adding Yang as a reviewer as he is more familiar with
this code.
https://codereview.chromium.org/21761002/diff/1/src/messages.js
File src/messages.js (right):
https://codereview.chromium.org/21761002/diff/1/src/messages.js#newcode232
src/messages.js:232: (obj instanceof $Error && obj.toString ===
$Error.prototype.toString)) {
As discussed offline: I am a little bit worried that the "obj.toString"
access here is observable and might throw an exception, or even worse
return different values every other time. Better use
"GetPropertyWithoutInvokingMonkeyGetters" to get to the value of the
"toString" property.
Also "$Error.prototype.toString" is configurable and might not point to
the primordial implementation, it would be better to compare against
"ErrorToString" instead.
https://codereview.chromium.org/21761002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
