On 2013/08/02 12:16:01, Michael Starzinger wrote:
LGTM with one final comment to address. I would still wait for Yang's
approval
though.
https://codereview.chromium.org/21761002/diff/8001/src/messages.js
File src/messages.js (right):
https://codereview.chromium.org/21761002/diff/8001/src/messages.js#newcode231
src/messages.js:231: var objToString =
GetPropertyWithoutInvokingMonkeyGetters(obj, "toString");
Yep, better, final nit: Can we move this into the "IsNativeErrorObject"
helper
to not duplicate it at all use-sites of that helper?
Hrm. You're right, that function isn't used anywhere else.
I'd intentionally avoided changing its meaning, but since these are the only
callsites it probably makes sense to just rename it (to
"CanBeSafelyTreatedAsAnErrorObject"?) and update the comment.
https://codereview.chromium.org/21761002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
