Thanks, Michael. I look forward to what Yang has to say next week. :)


https://codereview.chromium.org/21761002/diff/1/src/messages.js
File src/messages.js (right):

https://codereview.chromium.org/21761002/diff/1/src/messages.js#newcode232
src/messages.js:232: (obj instanceof $Error && obj.toString ===
$Error.prototype.toString)) {
On 2013/08/02 11:47:04, Michael Starzinger wrote:
As discussed offline: I am a little bit worried that the
"obj.toString" access
here is observable ...

Also "$Error.prototype.toString" is configurable ...

Both these suggestions make sense, and are in the latest patchset.

Thanks for taking a look!

https://codereview.chromium.org/21761002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to