https://codereview.chromium.org/21536003/diff/3001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/21536003/diff/3001/src/hydrogen-instructions.h#newcode1089
src/hydrogen-instructions.h:1089: virtual int CompareOperandCount() {
return OperandCount(); }
See comment below about storing the context explicitly.
https://codereview.chromium.org/21536003/diff/3001/src/hydrogen-instructions.h#newcode2870
src/hydrogen-instructions.h:2870: class HCheckMaps: public
HTemplateInstruction<3> {
It seems to me this class would be much cleaner if you just stored the
context internally in a hand-allocated field of the class rather than
one of the built-in fields of the HTemplateInstruction<>
https://codereview.chromium.org/21536003/diff/3001/src/ia32/lithium-ia32.h
File src/ia32/lithium-ia32.h (right):
https://codereview.chromium.org/21536003/diff/3001/src/ia32/lithium-ia32.h#newcode2440
src/ia32/lithium-ia32.h:2440: class LCheckMaps: public
LTemplateInstruction<0, 2, 0> {
I think these are not needed given my previous comments.
https://codereview.chromium.org/21536003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
