Addressed comments.
https://chromiumcodereview.appspot.com/21536003/diff/18002/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://chromiumcodereview.appspot.com/21536003/diff/18002/src/ia32/lithium-codegen-ia32.cc#newcode5801
src/ia32/lithium-codegen-ia32.cc:5801: Runtime::kMigrateInstance, 1,
instr, instr->context());
On 2013/08/05 14:36:59, danno wrote:
I think you can make the code much smaller and simplify things even
more if you
don't use CallRuntimeFromDeferred here at all. Perhaps just a new
version called
CallRuntimeFromDeferredNoContext that just does:
__ xor (esi, esi)
__ CallRuntimeSaveDoubles(id);
__ RecordSafepointWithRegisters(instr->pointer_map(), argc,
Safepoint::kNoLazyDeopt);
Done.
https://chromiumcodereview.appspot.com/21536003/diff/18002/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):
https://chromiumcodereview.appspot.com/21536003/diff/18002/src/ia32/lithium-ia32.cc#newcode2072
src/ia32/lithium-ia32.cc:2072: context = UseConstant(clobber_value);
On 2013/08/05 14:36:59, danno wrote:
I don't think you need any of this new logic, do you? The context
register isn't
used, the code can stay the same, right?
Done.
https://chromiumcodereview.appspot.com/21536003/diff/18002/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
https://chromiumcodereview.appspot.com/21536003/diff/18002/src/x64/lithium-codegen-x64.cc#newcode4976
src/x64/lithium-codegen-x64.cc:4976: class DeferredInstanceMigration:
public LDeferredCode {
On 2013/08/05 14:36:59, danno wrote:
Do you want this class here or in the outer scope somewhere? It seems
like you
might want to use it for other stuff at some point. Otherwise, it
probably
should just be called DeferredCheckMaps.
Done.
https://chromiumcodereview.appspot.com/21536003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
