Addressed feedback. Given that the context is actually irrelevant for
instance
migration, I removed the context slot from HCheckMaps, and clobbered the
context
register for the runtime call with smi-0.
https://chromiumcodereview.appspot.com/21536003/diff/3001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://chromiumcodereview.appspot.com/21536003/diff/3001/src/hydrogen-instructions.h#newcode1089
src/hydrogen-instructions.h:1089: virtual int CompareOperandCount() {
return OperandCount(); }
On 2013/08/05 10:07:36, danno wrote:
See comment below about storing the context explicitly.
Done.
https://chromiumcodereview.appspot.com/21536003/diff/3001/src/hydrogen-instructions.h#newcode2870
src/hydrogen-instructions.h:2870: class HCheckMaps: public
HTemplateInstruction<3> {
On 2013/08/05 10:07:36, danno wrote:
It seems to me this class would be much cleaner if you just stored the
context
internally in a hand-allocated field of the class rather than one of
the
built-in fields of the HTemplateInstruction<>
Done.
https://chromiumcodereview.appspot.com/21536003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
