https://codereview.chromium.org/22379002/diff/22001/src/optimizing-compiler-thread.cc
File src/optimizing-compiler-thread.cc (right):
https://codereview.chromium.org/22379002/diff/22001/src/optimizing-compiler-thread.cc#newcode76
src/optimizing-compiler-thread.cc:76: FlushOutputQueue(true);
You could flush the output queue in the main thread, since this is the
consumer of the queue. But it is also safe to flush it here.
https://codereview.chromium.org/22379002/diff/22001/src/optimizing-compiler-thread.cc#newcode169
src/optimizing-compiler-thread.cc:169: // happens in CompileNext on the
same thread.
Can we add a comment that we need that code just for testing purposes.
https://codereview.chromium.org/22379002/diff/22001/src/optimizing-compiler-thread.cc#newcode174
src/optimizing-compiler-thread.cc:174: FlushOutputQueue(false);
Can we call flush in the main thread before calling stop? Flushing of
the output queue could still be done here.
https://codereview.chromium.org/22379002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
