LGTM! With one comment.
https://codereview.chromium.org/22379002/diff/31001/src/optimizing-compiler-thread.cc
File src/optimizing-compiler-thread.cc (right):
https://codereview.chromium.org/22379002/diff/31001/src/optimizing-compiler-thread.cc#newcode77
src/optimizing-compiler-thread.cc:77: NoBarrier_Store(&queue_length_,
static_cast<AtomicWord>(0));
I think we need a memory barrier for both stores on ARM. WDYT?
https://codereview.chromium.org/22379002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
