LGTM (if nits are addressed).
https://codereview.chromium.org/22379002/diff/28001/src/optimizing-compiler-thread.cc
File src/optimizing-compiler-thread.cc (right):
https://codereview.chromium.org/22379002/diff/28001/src/optimizing-compiler-thread.cc#newcode74
src/optimizing-compiler-thread.cc:74: { AllowHandleDereference
allow_handle_dereference;
nit: Since the AllowHandleDereference scope is only for debugging
purposes, can we move it into FlushInputQueue to simplify this call-site
and keep the two flushing methods in sync?
https://codereview.chromium.org/22379002/diff/28001/src/optimizing-compiler-thread.cc#newcode126
src/optimizing-compiler-thread.cc:126: input_queue_semaphore_->Wait();
nit: Since this is only safe when being called in the compiler thread,
can we add an ASSERT(IsOptimizerThread()) right here above the wait,
below the comments.
https://codereview.chromium.org/22379002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
