On 2013/08/19 08:32:40, Yury Semikhatsky wrote:
On 2013/08/19 07:58:09, Benedikt Meurer wrote:
> I don't want to introduce any more #ifdef's here. I think we should
simply
> import the base/time stuff from chromium instead, which already covers
what
we
> need.
Ho do you see it? Pulling src/base as a third-party library sounds like an
overkill. On ther other hand we cannot simply import base/time as it
depends
on
other classes in base/ So another option would be to import base/time
without
dependencies and change it to use types available in v8. This way we
would end
up having two copies of base/time in Chromium.
What I mean is import on a functional level, not just copy the source code.
I'll
probably look into that during the week as I plan to cleanup the time delta
code
in V8 as well.
https://codereview.chromium.org/23271003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
