Looks way better now. :-)
LGTM with comment
https://codereview.chromium.org/23271003/diff/20001/src/sampler.cc
File src/sampler.cc (right):
https://codereview.chromium.org/23271003/diff/20001/src/sampler.cc#newcode614
src/sampler.cc:614: #elif defined(_WIN32) || defined(_WIN64) ||
defined(__CYGWIN__)
You don't need to test for _WIN64, since _WIN32 is defined for both 32
and 64 bit windows.
Please convert to use V8_OS_* macros, so we can get rid of this platform
specific defines at some point:
#elif V8_OS_WIN || V8_OS_CYGWIN
https://codereview.chromium.org/23271003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
